Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nv14/el18): Battery charging #5172

Closed
wants to merge 2 commits into from
Closed

fix(nv14/el18): Battery charging #5172

wants to merge 2 commits into from

Conversation

richardclli
Copy link
Collaborator

@richardclli richardclli commented Jun 13, 2024

This PR disables the use of direct drawing for firmware:

#5068

which breaks the charging UI in Flysky radios (NV14, EL18, PL18, PL18EV, etc.)

This PR provide a quick fix, the charging mechanism will be reworked later on according to

#2794

Replaced by a better implementation:
#5237

@richardclli richardclli self-assigned this Jun 13, 2024
@richardclli richardclli added this to the 2.11 milestone Jun 13, 2024
@richardclli richardclli changed the title Fix nv14/el18 charging fix(nv14/el18): Battery charging Jun 13, 2024
@pfeerick
Copy link
Member

Would probably be better to limit this to those radios, or even simpler, flysky radios generally, so this doesn't clash with h7 (the whole reason that other PR exists ;) )

@richardclli
Copy link
Collaborator Author

richardclli commented Jun 14, 2024

Would probably be better to limit this to those radios, or even simpler, flysky radios generally, so this doesn't clash with h7 (the whole reason that other PR exists ;) )

I already added remarks to the code, these will be reverted once the charging mechanism is reworked.

BTW, this PR fixed one more BUG introduced by obsolete-stdperiph if you take a look on what I have changed.

@raphaelcoeffic
Copy link
Member

I believe we can make it possible on runtime in general, with just some parameter in the LCD init. I’ll try to see if there are any conflicts that way. But clearly, we should offer a way to use LVGL proper in such applications as well (charging screen).

@richardclli
Copy link
Collaborator Author

I believe we can make it possible on runtime in general, with just some parameter in the LCD init. I’ll try to see if there are any conflicts that way. But clearly, we should offer a way to use LVGL proper in such applications as well (charging screen).

@raphaelcoeffic Any progress?

@richardclli richardclli force-pushed the fix-el18-charging branch 2 times, most recently from 98200e1 to ad334eb Compare June 28, 2024 04:34
@richardclli
Copy link
Collaborator Author

Replaced by a better implementation:
#5237

@pfeerick pfeerick deleted the fix-el18-charging branch August 2, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants