fix: RTC warning not being shown #5209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partially revert change in #5031 re: `enableVBatBridge()` as this needs to be called reguarly so that the RTC voltage is actually read. The call to `disableVBatBridge()` while perhaps technically not needed since `adcRead()` will clear it itself once the voltage actually read certainly won't hurt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
As in fix: RTC boot check not working #5207, enable the vBatBridge when needed on the startup run of
checkAll()so that the RTC battery voltage is actually read.Partially revert change in refactor(color): UI code cleanup, speed up loading of complex pages #5031 re:
enableVBatBridge()as this needs to be called regularly so that the RTC voltage is actually read. The call todisableVBatBridge()while perhaps technically not needed sinceadcRead()will clear it itself once the voltage actually read certainly won't hurt.Changes to display of number on hardware page required as was occasionally flashing junk characters and number changing alignment.
Fixes #5203 for main
Tested on TX16S hardware by running separate PSU on RTC battery input to allow for voltage to be adjusted.