Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh Windows, Linux and Mac Companion icons + helper script #565

Merged
merged 9 commits into from
Aug 14, 2021

Conversation

pfeerick
Copy link
Member

@pfeerick pfeerick commented Aug 6, 2021

Simple icon generator tool that grabs the icon from the website repo, and uses it to create the linux and windows icons.

Caveats:

  • it doesn't do the SVG scalable icon for linux, as I can't readily find find a PNG => SVG conversion module.
  • pillow (the image toolkit) doesn't do all the windows icon sizes, so some of them are different sizes - but I would also question if all those sizes are actually needed, as pillow only supports the "standard" sizes
  • havn't even considered the mac icon ;)

Should help a bit with #555 (not to be confused with the triple 5 timer!)

@elecpower
Copy link
Collaborator

@pfeerick you can change generated file names in images/winicons to edgetx prefix and edit icon.rc and all should work if not on me to fix.

@pfeerick
Copy link
Member Author

pfeerick commented Aug 6, 2021

Ask and ye shall receive ;)

@elecpower
Copy link
Collaborator

  • it doesn't do the SVG scalable icon for linux, as I can't readily find find a PNG => SVG conversion module.

From my searching seems base image is generally svg and other formats derived from it

@pfeerick
Copy link
Member Author

pfeerick commented Aug 7, 2021

Yeah, that is the way it should be, since SVG is the infinitely scalable version... but it is possible to convert the other way for those "just need it in SVG to satisfy requirement X" moments... Since I've also done the other images, I might just use a online converter and do just replace it.

@pfeerick
Copy link
Member Author

pfeerick commented Aug 7, 2021

Screw it... Inkscape PNG to SVG save it is... online converters were useless. It isn't ideal, as it won't be properly scaleable (upwards, at least), but at least if something in companion uses it it will be the correct logo. I suspect it was probably the source image for all the other icons though.

@pfeerick pfeerick changed the title iconGenerator iconGenerator and refresh Windows and Linux Companion icons Aug 7, 2021
@elecpower
Copy link
Collaborator

elecpower commented Aug 7, 2021

I'll see how clever you are when I next compile and test companion ;-)

@elecpower
Copy link
Collaborator

elecpower commented Aug 8, 2021

Tested on Ubuntu and we need a file to replace images/icon.png size 96 x 96 pixels.
I made a temp one up from your svg, compiled and success.
Needs testing on Windows and when @JimB40 has time to generate a new iconmac.icns on OSX after he has his hands on a OSX dmg.
Many thanks for your help ;-)

@pfeerick
Copy link
Member Author

pfeerick commented Aug 8, 2021

Like so? One of these days, I think we should be able to go through all of these and remove most of them... probably find out we only need a handful of the 'icon' graphics.

@elecpower
Copy link
Collaborator

Found this python script for icns https://github.com/retifrav/python-scripts/tree/master/generate-iconset. It is licensed under MIT.

@elecpower
Copy link
Collaborator

One of these days,

Yeah when there are no open issues, all PRs merged, no new radio hardware, no new protocols, the devs are in covid lockdown or can't sleep...of course LOL

@pfeerick
Copy link
Member Author

pfeerick commented Aug 8, 2021

Oh, nice... so ImageMagick can be used for that file... thanks for that! Ok, that will be tomorrows commit. You've had my quota of brain cells for the weekend 😜 Plus I'm in mourning over the loss of my Taranis X9D+... 😿

@elecpower elecpower mentioned this pull request Aug 8, 2021
15 tasks
Completely untested Mac gen of icon library, and tested linux gen.
@elecpower
Copy link
Collaborator

You need to change the title of this PR again ;-)
FYI I've created title and splash images for companion in my big PR just to change the branding. Someone with some real gfx skills could have a go later.

@pfeerick
Copy link
Member Author

pfeerick commented Aug 9, 2021

I was hoping no-one would notice... although I suppose the native mac generation code is basically someone elses (with attribution)... so if it's broken I can deny all knowledge, especially cause I'm too lazy to bother running up a MacOS VM again... 😆

@pfeerick pfeerick changed the title iconGenerator and refresh Windows and Linux Companion icons Refresh Windows and Linux Companion icons + helper script Aug 9, 2021
@pfeerick pfeerick changed the title Refresh Windows and Linux Companion icons + helper script Refresh Windows, Linux and Mac Companion icons + helper script Aug 9, 2021
@raphaelcoeffic raphaelcoeffic merged commit 88f8626 into main Aug 14, 2021
@pfeerick pfeerick deleted the iconGenerator branch August 14, 2021 09:20
@pfeerick pfeerick added this to the 2.5 milestone Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants