-
-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh Windows, Linux and Mac Companion icons + helper script #565
Conversation
@pfeerick you can change generated file names in images/winicons to edgetx prefix and edit icon.rc and all should work if not on me to fix. |
Ask and ye shall receive ;) |
From my searching seems base image is generally svg and other formats derived from it |
Yeah, that is the way it should be, since SVG is the infinitely scalable version... but it is possible to convert the other way for those "just need it in SVG to satisfy requirement X" moments... Since I've also done the other images, I might just use a online converter and do just replace it. |
Screw it... Inkscape PNG to SVG save it is... online converters were useless. It isn't ideal, as it won't be properly scaleable (upwards, at least), but at least if something in companion uses it it will be the correct logo. I suspect it was probably the source image for all the other icons though. |
I'll see how clever you are when I next compile and test companion ;-) |
Tested on Ubuntu and we need a file to replace images/icon.png size 96 x 96 pixels. |
Like so? One of these days, I think we should be able to go through all of these and remove most of them... probably find out we only need a handful of the 'icon' graphics. |
Found this python script for icns https://github.com/retifrav/python-scripts/tree/master/generate-iconset. It is licensed under MIT. |
Yeah when there are no open issues, all PRs merged, no new radio hardware, no new protocols, the devs are in covid lockdown or can't sleep...of course LOL |
Oh, nice... so ImageMagick can be used for that file... thanks for that! Ok, that will be tomorrows commit. You've had my quota of brain cells for the weekend 😜 Plus I'm in mourning over the loss of my Taranis X9D+... 😿 |
Completely untested Mac gen of icon library, and tested linux gen.
You need to change the title of this PR again ;-) |
I was hoping no-one would notice... although I suppose the native mac generation code is basically someone elses (with attribution)... so if it's broken I can deny all knowledge, especially cause I'm too lazy to bother running up a MacOS VM again... 😆 |
Simple icon generator tool that grabs the icon from the website repo, and uses it to create the linux and windows icons.
Caveats:
Should help a bit with #555 (not to be confused with the triple 5 timer!)