Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows companion build #706

Closed
wants to merge 3 commits into from
Closed

Windows companion build #706

wants to merge 3 commits into from

Conversation

raphaelcoeffic
Copy link
Member

@raphaelcoeffic raphaelcoeffic commented Sep 11, 2021 •
edited
Loading

This PR is aimed at compiling Companion for Windows with Github Actions.

This new system uses:

  • MSYS2
  • GCC 10.3
  • Qt 5.12.9 (from aqtinstall)

It is noteworthy that the compatibility with MSVC was/is broken. For my part, I won't share a single tear 😇

Please note that #561 is based on this PR as well.

@elecpower
Copy link
Collaborator

Just in case you hadn't noticed ie buried in errors, build using Qt 5.15 libraries and thus depreciated warnings. The docker build and hence my dev and testing uses 5.11.

@elecpower
Copy link
Collaborator

elecpower commented Sep 11, 2021 •
edited
Loading

PR #446 that will remove some of the depreciation warnings and compatible with 5.11

@elecpower
Copy link
Collaborator

A quick and dirty rename of the RGB define to say CPN_RBG is fine by me as it will not be needed in the next iteration of the colorlcd code that I'm working on.

@pfeerick pfeerick added the companion Related to the companion software label Sep 12, 2021
@rotorman
Copy link
Member

rotorman commented Sep 12, 2021 •
edited
Loading

I tested this branch (wrote also instructions using it https://github.com/EdgeTX/edgetx/wiki/Build-Instructions-under-Windows-10-%28MSYS2%29 ), works nicely under Windows 10 64-bit.
I was able to build radio firmware for TX16S, Companion binary, Simulator binary, radio simulator library for TX16S and package the installer.

Only thing not working yet is the compact simu (make simu) under Windows 10 with MSYS2. Gives me:
make: *** No rule to make target 'simu'. Stop.

@raphaelcoeffic raphaelcoeffic marked this pull request as ready for review September 12, 2021 13:11
@raphaelcoeffic raphaelcoeffic mentioned this pull request Sep 12, 2021
Merged
@rotorman
Copy link
Member

Here some nice feedback to this PR and also to #555 / Companion from RCGroups:
https://www.rcgroups.com/forums/showthread.php?3916381-Official-EdgeTX-Version-2-4-0-Endeavour-Discussion-Thread/page45#post47804799

@raphaelcoeffic
Copy link
Member Author

Superseded by #561

@raphaelcoeffic raphaelcoeffic deleted the win-cpn branch September 14, 2021 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elecpower elecpower Awaiting requested review from elecpower

Assignees
No one assigned
Labels
companion Related to the companion software
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@raphaelcoeffic @elecpower @rotorman @pfeerick