Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom binary location #47

Merged
merged 2 commits into from Jan 8, 2017
Merged

Custom binary location #47

merged 2 commits into from Jan 8, 2017

Conversation

zdenekdrahos
Copy link
Member

  • detect composer bin dir in common paths or use env variable COMPOSER_BIN_DIR
  • stop phpqa if bin-dir is in unknown location

Closes #46

Copy link
Member

@sojki sojki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zdenekdrahos I was thinking about "How to easily get bin-dir configuration from composer.json without actually parsing it". The only idea I found is, that we can (with robo) call "composer config bin-dir" to access that configuration.

@zdenekdrahos zdenekdrahos merged commit 06bd832 into master Jan 8, 2017
@zdenekdrahos zdenekdrahos deleted the composer-bin-dir branch January 8, 2017 09:02
zdenekdrahos added a commit that referenced this pull request Aug 31, 2019
closes #182

v1.9
- installed.json introduced in 51b8a5c
- Only COMPOSER_BINARY_DIR was defined in https://github.com/EdgedesignCZ/phpqa/blob/51b8a5c/phpqa
- bin-dir fixed in #47

v1.12
- COMPOSER_VENDOR_DIR constant introduced in d8d5519
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants