implement socket encoding and bufferlength #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhoninl
requested review from
saiyan86,
seanli33056,
tomqin93 and
BtXin
as code owners
BtXin
suggested changes
Sep 23, 2022
Codecov ReportBase: 22.58% // Head: 22.15% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #268 +/- ##
==========================================
- Coverage 22.58% 22.15% -0.43%
==========================================
Files 8 8
Lines 837 835 -2
==========================================
- Hits 189 185 -4
- Misses 629 633 +4
+ Partials 19 17 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
tomqin93
requested changes
Sep 25, 2022
tomqin93
requested changes
Sep 26, 2022
tomqin93
reviewed
Sep 26, 2022
tomqin93
reviewed
Sep 27, 2022
kris21he
reviewed
Sep 27, 2022
kris21he
reviewed
Sep 27, 2022
tomqin93
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
implement socket encoding and bufferlength
Will this PR make the community happier?
yes
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #How is this PR tested
Special notes for your reviewer:
Release note: