Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the field from "telemetrySeriveEndpoint" to "telemetryServiceEndpoint" #837

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

p-mega
Copy link
Contributor

@p-mega p-mega commented Feb 29, 2024

What this PR does / why we need it:

The PR is fixed the misspelling telemetrySeriveEndpoint

Will this PR make the community happier?

Yes

Which issue this PR fixes:

fixes #832

How is this PR tested

  • unit test
  • e2e test

Special notes for your reviewer:

Release note:

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.91%. Comparing base (8a0cc59) to head (c50276e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #837      +/-   ##
==========================================
+ Coverage   54.78%   54.91%   +0.13%     
==========================================
  Files          23       23              
  Lines        2287     2287              
==========================================
+ Hits         1253     1256       +3     
+ Misses        919      917       -2     
+ Partials      115      114       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rhoninl
Copy link
Collaborator

rhoninl commented Mar 6, 2024

The title of this PR is incorrect and should be changed to Change the field from "telemetrySeriveEndpoint" to "telemetryServiceEndpoint"

Copy link
Collaborator

@rhoninl rhoninl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@p-mega p-mega changed the title change the field "telemetryServiceEndpoint" to "telemetrySeriveEndpoint" Change the field from "telemetrySeriveEndpoint" to "telemetryServiceEndpoint" Mar 6, 2024
Copy link
Contributor

@kris21he kris21he left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kris21he kris21he merged commit 8cfefc8 into main Mar 6, 2024
15 checks passed
@kris21he kris21he deleted the fix_misspelling branch March 6, 2024 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

maybe one spelling mistake.
5 participants