Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Auth with Username and Password for TelemetryService MQTT #873

Merged
merged 16 commits into from
Apr 10, 2024

Conversation

rhoninl
Copy link
Collaborator

@rhoninl rhoninl commented Apr 9, 2024

What this PR does / why we need it:
Some MQTT Endpoint need to config username or password to conenct it
Will this PR make the community happier?

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

How is this PR tested

  • unit test
  • e2e test
  • other (please specify)

Special notes for your reviewer:

Release note:

- update telemetryService MQTT Secret inject Logic
- Add MQTTServerUserName to allow user to Auth with UserName and Password
- Update CRD add MQTTServerUserName to allow user to input Username using plaintext

Copy link
Contributor

@tomqin93 tomqin93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include document changes as well

@rhoninl
Copy link
Collaborator Author

rhoninl commented Apr 10, 2024

Please include document changes as well

Edgenesis/shifu.dev#297

@rhoninl rhoninl requested a review from tomqin93 April 10, 2024 03:32
Copy link
Contributor

@tomqin93 tomqin93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rhoninl added some comment, please take a look

pkg/deviceshifu/deviceshifumqtt/deviceshifumqtt.go Outdated Show resolved Hide resolved
Copy link
Contributor

@tomqin93 tomqin93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rhoninl added 1 minor comment, need to add tests for username+password for telemetryservicemqtt

pkg/telemetryservice/mqtt/telemetryservicemqtt.go Outdated Show resolved Hide resolved
@rhoninl rhoninl requested a review from tomqin93 April 10, 2024 09:04
@rhoninl rhoninl requested a review from tomqin93 April 10, 2024 09:53
Copy link
Contributor

@tomqin93 tomqin93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomqin93 tomqin93 merged commit 784ed4d into main Apr 10, 2024
12 of 13 checks passed
@tomqin93 tomqin93 deleted the auth_mqtt_telemetry branch April 10, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants