Biopython v1.78 compatibility #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method returns an error, beacuse StickyEndSeq has no `annotations` that can be set. All circularized() calls in the codebase are made from StickyEndFragment or HomologousFragment.
|
Re commit 44c6fda, method I propose to remove method circularized() from StickyEndSeq because it's never accessed (all calls are from StickyEndFragment or HomologousFragment), and sequences (Seq) do not have topology, but records (SeqRecord) do. @Zulko please let me know if I missed something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StickyEndSeq.circularized()method that has a runtime error and is not neededAll examples ran fine without errors.