Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check the existence of bcls #384

Merged
merged 9 commits into from
Mar 18, 2019
Merged

Check the existence of bcls #384

merged 9 commits into from
Mar 18, 2019

Conversation

tcezard
Copy link

@tcezard tcezard commented Mar 15, 2019

Check that the bcl exists before the returning the number of existing cycles
closes #382

@tcezard tcezard added this to the v0.24.1 milestone Mar 15, 2019
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 72.268% when pulling c140bbe on 382_check_bcl_exists_for_cycle into 096af2f on master.

@coveralls
Copy link

coveralls commented Mar 15, 2019 •
edited

Coverage Status

Coverage increased (+0.02%) to 72.59% when pulling 65b1c8a on 382_check_bcl_exists_for_cycle into 096af2f on master.

lukbut
lukbut reviewed Mar 15, 2019
View reviewed changes
Copy link
Collaborator

@lukbut lukbut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have gone through the code and have the following comments, but I do not feel I can vouch for the changes in technical functionality as I am not familiar with this part of the code at all.

analysis_driver/quality_control/interop_metrics.py Outdated Show resolved Hide resolved
analysis_driver/quality_control/interop_metrics.py Outdated Show resolved Hide resolved
analysis_driver/quality_control/interop_metrics.py Outdated Show resolved Hide resolved
tests/test_pipelines/test_demultiplexing.py Show resolved Hide resolved
@tcezard tcezard merged commit 507fb41 into master Mar 18, 2019
@tcezard
Copy link
Author

tcezard commented Mar 18, 2019

This PR will not go through validation as it address an urgent bug. The change does not modify any feature that can influence the data or the metrics but only when the data will start being processed.

@mwhamgenomics mwhamgenomics deleted the 382_check_bcl_exists_for_cycle branch March 27, 2019 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukbut lukbut lukbut left review comments

@mwhamgenomics mwhamgenomics mwhamgenomics approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.24.1
Development

Successfully merging this pull request may close these issues.

Searching for current cycle when they do not exist yet breaks
4 participants
@tcezard @coveralls @mwhamgenomics @lukbut