Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CR1837- email_manifest_tracking_letter_customer.py minor change to script and template #102

Merged
merged 2 commits into from
Sep 13, 2019

Conversation

EGCGDanForth
Copy link
Collaborator

  • nolonger attachs tracking letter to emails for standard tube emails.

-customer_manifest.html - template text updated
-test updated correspondingly

…g letter to emails for standard tube emails.

customer_manifest.html - template text updated
test updated correspondingly
@coveralls
Copy link

coveralls commented Aug 23, 2019

Coverage Status

Coverage decreased (-0.007%) to 76.36% when pulling 0f0fc9b on CR1837 into 8bff040 on master.

@EGCGDanForth EGCGDanForth changed the title email_manifest_tracking_letter_customer.py minor change to script and template CR1837- email_manifest_tracking_letter_customer.py minor change to script and template Aug 26, 2019
<br>Please find attached the following two documents:<br>
Thank you for choosing to use our sequencing service again. Please find attached the following two documents:<br>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for choosing to use our sequencing service again

Are we assuming this will always be a returning customer?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new project team has requested a range of text that covers most possible scenarios and they will delete what they don't need.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should add that the project team reviewed the template text prior to the pull request.

<br>1) Sample Manifest &#8208; please complete all of the fields in the green columns that are relevant to your samples and return the file to EGCG-Projects@ed.ac.uk. We can only begin processing when both the manifest and samples have been received at Edinburgh Genomics.<br>
<br>2) Sample Submission Requirements &#8208; this document provides guidance on preparing and shipping your samples to Edinburgh Genomics Clinical.<br>
<br>Please note that we will require the sample(s) to have a concentration of <b>>=50ng/ul</b> at a volume of <b>>= 50 ul</b>. The sample(s) should only be shipped to us in the barcoded container(s) that we will provide. Plates must be sent frozen on dry-ice but tubes may be sent at ambient temperature.</p>
<br>Please note that we will require the sample(s) to have a concentration of <b>>=50ng/ul</b> at a volume of <b>>= 50 ul</b>. The sample(s) should only be shipped to us in the barcoded container(s) that we will provide. Plates must be sent frozen on dry-ice but tubes may be sent at ambient temperature.<br>
<br><span style="color: #ff0000">An order has been placed for the shipment of the sample collection containers to you and these are estimated to arrive on WEEK-DAY DD-MM-YYYY/The container(s) will be placed in your Roslin mailbox by TIME DAY.</span> If you have any questions about samples submission then please don't hesitate to contact me.</p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The container(s) will be placed in your Roslin mailbox by TIME DAY

Same thing - are we assuming customers will always be at Roslin?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above, The new project team has requested a range of text that covers most possible scenarios and they will delete what they don't need.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should add that the project team reviewed the template text prior to the pull request.

Copy link
Collaborator

@mwhamgenomics mwhamgenomics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per review comments, I think the placeholder text makes it too easy to accidentally leave in the wrong content, but it's what the project team asked for.

@EGCGDanForth EGCGDanForth merged commit 1bc107a into master Sep 13, 2019
@mwhamgenomics mwhamgenomics deleted the CR1837 branch November 21, 2019 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants