Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queued artifacts #19

Merged
merged 4 commits into from
Jan 10, 2018
Merged

Queued artifacts #19

merged 4 commits into from
Jan 10, 2018

Conversation

tcezard
Copy link

@tcezard tcezard commented Jan 3, 2018

Properly parse the queued artifacts to retrieve the artifacts and the timed they were queued.
queued_artifacts returns alist of tuple such as:

queued_artifacts =  [
    (Artifact(), datetime(...), (Container(), 'H11')),
    (Artifact(), datetime(...), (Container(), 'H12')), 
]

In python 3 the datetime object will have a time zone where it will be ignored in python 2.7
closes #18

@coveralls
Copy link

coveralls commented Jan 3, 2018

Coverage Status

Coverage decreased (-0.2%) to 76.431% when pulling 6a228c1 on queued_artifacts into 82c1b93 on master.


def _parse_element(self, element, lims, **kwargs):
from pyclarity_lims.entities import Artifact, Container
input = Artifact(lims, uri=element.attrib['uri'])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shadows input built-in

@coveralls
Copy link

coveralls commented Jan 9, 2018

Coverage Status

Coverage increased (+0.4%) to 77.044% when pulling bed8bb9 on queued_artifacts into 82c1b93 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 77.044% when pulling bed8bb9 on queued_artifacts into 82c1b93 on master.

@tcezard tcezard merged commit 834cb0a into master Jan 10, 2018
@Rubyj
Copy link

Rubyj commented Jan 10, 2018

Any idea when this feature will be rolled out in an official version? (0.4.2 or whatever the next will be)

@tcezard
Copy link
Author

tcezard commented Jan 10, 2018

released now in 0.4.2

@tcezard tcezard deleted the queued_artifacts branch May 11, 2018 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Queue Class does not have an easily acessible "queue-time" member variable
4 participants