Fix clear function #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 22, 2018 21:19
Use nesting in SubtagDictionary to make sure rootnode return the node associated with provided tag
| XmlDictionary.__init__(self, instance) | ||
|
|
||
| def _update_elems(self): | ||
| tag_node = self.rootnode(self.instance).find(self.tag) |
There was a problem hiding this comment.
Is the call to rootnode.find redundant, or will removing it cause a behaviour change?
There was a problem hiding this comment.
Because of the use of nesting in the __init__, self.rootnode() now returns the node of the tag making this function simpler and allowing the clear() function to work as expected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
clearfunction inXmlDictionaryandXmlListwere both eagerly removing all elements of the rootnode even if those elements were not being parsed.In object where the rootnode is shared running
list.clear()was removing all elements of the rootnode.This PR will fix this by only removing elements that have been parsed.
I also had to change the way
SubTagDictionaryis finding its rootnode by using theNestableclass.fixes #23