Start_index and depagination #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…option `nb_page` specify how many pages should be added after.
|
Setting BTW, thank you for this package. It makes working with Clarity LIMS much easier. |
mwhamgenomics
requested changes
May 15, 2018
pyclarity_lims/lims.py
Outdated
| @@ -560,14 +582,15 @@ def _get_params_udf(self, udf=dict(), udtname=None, udt=dict()): | |||
| result["udt.%s" % key] = value | |||
| return result | |||
|
|
|||
| def _get_instances(self, klass, add_info=None, params=dict()): | |||
| def _get_instances(self, klass, add_info=None, nb_page=-1, params=dict()): | |||
There was a problem hiding this comment.
Can we make this nb_pages, to reaffirm that we're returning multiple pages, rather than one specific page?
mwhamgenomics
approved these changes
May 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
start_indexwhich now only specify the first element return. A new parameternb_pagespecify how many pages to return.nb_page=-1which is default return all pages available from thestart_indexfixes #32