Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug while trying to use the plugin #62

Open
clemrdh opened this issue Jun 15, 2022 · 6 comments
Open

Bug while trying to use the plugin #62

clemrdh opened this issue Jun 15, 2022 · 6 comments

Comments

@clemrdh
Copy link

clemrdh commented Jun 15, 2022

Just trying to use the plugin (0.6.1) in win10, with koReader (last version) on D:\ and the Obsidian storage on H:\ .

plugin:obsidian-koreader-plugin:12787 Uncaught (in promise) TypeError: Cannot read property '0' of null
at KOReader.eval (plugin:obsidian-koreader-plugin:12787)
at Generator.next ()
at eval (plugin:obsidian-koreader-plugin:63)
at new Promise ()
at __async (plugin:obsidian-koreader-plugin:47)
at KOReader.createNote (plugin:obsidian-koreader-plugin:12785)
at KOReader.eval (plugin:obsidian-koreader-plugin:12925)
at Generator.next ()
at fulfilled (plugin:obsidian-koreader-plugin:50)

-> Apparently caused by const page = bookmark.text ? parseInt(bookmark.text.match(/\d+/g)[0]) : -1;
-> text.match() is null, so [0] is incorrect.

I don't know if this is due to unaccepted characters in the Book title or other bugs ?

Uncaught (in promise) Error: ENOENT: no such file or directory, mkdir 'H:\Nextcloud\ ...-Christian Arnsperger
Dominique Bourg'

Uncaught (in promise) Error: ENOENT: no such file or directory, open 'H:\Nextcloud\DOCUMENTS\NOTES\OBSIDIAN\04-Other\KoReader_HIghlights(book) Ecologie intégrale_ Pour ...-Christian Arnsperger
Dominique Bourg\on constate que la méthod... - Christian Arnsperger
Dominique Bourg.md'

Uncaught (in promise) Error: ENOENT: no such file or directory, open 'H:\Nextcloud\DOCUMENTS\NOTES\OBSIDIAN\04-Other\KoReader_HIghlights(book) Ecologie intégrale_ Pour ...-Christian Arnsperger
Dominique Bourg\favoriserait une intensif... - Christian Arnsperger
Dominique Bourg.md'

@mthlvt
Copy link

mthlvt commented Aug 6, 2022

+1 had same issue, temporarily fixed it by removing highlights where I had a note added.

Seems Koreader data is different in this case which leads to parsing failure and the uncaught exception.

Steps to reproduce: add a highlight in koreader, then tap the highlight and add a note, try to sync again

image

@clemrdh
Copy link
Author

clemrdh commented Aug 26, 2022

Pitty, have forked and update the plugin : https://github.com/clemrdh/obsidian-koreader-sync/

Now it works with page numbers, notes, text, ec... all good 👍

@Edo78
Copy link
Owner

Edo78 commented Aug 26, 2022

Pitty, have forked and update the plugin : https://github.com/clemrdh/obsidian-koreader-sync/

Now it works with page numbers, notes, text, ec... all good 👍

Sorry I have no time right now but if you are kind enough to open a PR I'll do my best to approve it

@mthlvt
Copy link

mthlvt commented Sep 6, 2022

Pitty, have forked and update the plugin : https://github.com/clemrdh/obsidian-koreader-sync/
Now it works with page numbers, notes, text, ec... all good 👍

Sorry I have no time right now but if you are kind enough to open a PR I'll do my best to approve it

#64

@cedryck1
Copy link

cedryck1 commented Dec 18, 2022

@clemrdh

I had the same problem.
Look in the .lua file (in your metadata folder of the book on your Koreader device (folder ending by .sdr)

Screenshot 2022-12-18 125357

Screenshot 2022-12-18 125426
When there are multiple authors, there may be a line skip with an antislash. Correct it in the .lua file so both authors are on the same line without line skip.

WHIT THE LINE SKIP CAUSING THE ISSUE
Screenshot 2022-12-18 125844

WITHOUT THE LINE SKIP (To fix the issue)
Screenshot 2022-12-18 125241

@thegreekgeek
Copy link

Hey is this ever going to get merged? I seem to be having this same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants