Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix highlights with notes #64

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Bugfix highlights with notes #64

wants to merge 2 commits into from

Conversation

mthlvt
Copy link

@mthlvt mthlvt commented Sep 6, 2022

Fork discussed at #62 (comment)

Could you please review ?

@Edo78
Copy link
Owner

Edo78 commented Sep 6, 2022

First things first thank you for your support to this small plugin.
I have just a couple of requests

  1. can you add a meaningful description to the README instead? Otherwise is preferable to revert it to its original content
  2. can you lint the code? there is a script defined in the package.json so npm run lint should help otherwise checking the diffs will be really hard

Thank you

@mthlvt
Copy link
Author

mthlvt commented Nov 19, 2022

First things first thank you for your support to this small plugin. I have just a couple of requests

1. can you add a meaningful description to the README instead? Otherwise is preferable to revert it to its original content

2. can you lint the code? there is a script defined in the package.json so `npm run lint` should help otherwise checking the diffs will be really hard

Thank you

Hi Edo78,
Even after linting the code, the diff is still hard to read.

@clemrdh could you help bring some clarity on the changes to merge the improvements you added in your fork please?

Thank you.

@mthlvt mthlvt marked this pull request as draft December 18, 2022 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants