Add set bit sort test #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a terminating instruction had a comment, the old code would not detect it properly. Switching from equals() to contains() fixes the issue. It is still not perfect (the test should be done *after* the instruction is built), but it's good enough.
Add set-bit-sort.s to unit tests. The program takes roughly 3 seconds to complete as a unit test, making it a good candidate as a performance regression test.
Codecov Report
@@ Coverage Diff @@
## master #155 +/- ##
============================================
+ Coverage 43.14% 43.94% +0.79%
- Complexity 1264 1291 +27
============================================
Files 241 241
Lines 10102 10104 +2
Branches 1137 1137
============================================
+ Hits 4359 4440 +81
+ Misses 5395 5326 -69
+ Partials 348 338 -10
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in Issue #132, adding a new program as a unit test. It completes in ~3 seconds on my machine as a unit test, making it a good regression test for performance issues.