Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have recently migrated to React v18 another project, and it's been painless so I thought it'd be the same for this one - oh boy, was I wrong. There's a few additional changes to make it work, due to some incompatibilities, APIs deprecation, introduction of new NPM packages, etc - a classic javascript version bump 馃槄
Basically:
@mui/*
now) and also changed the way it deals with themes and styles, so:@emotion/react
and@emotion/styled
)makeStyles
and similar functions are not supported anymore - or, more precisely, they still work as a legacy feature, but not with react v18: you'd need to use@mui/styles
, exceptindex.js
.I hope it makes sense (as much as it can..).
CSS is not exactly as before, and sometimes the MUI theme is prevailing (that's why I tried putting
!important
on some rules), but that can be fixed later I guess.馃憢
Other references:
makeStyles
returnsnever
聽mui/material-ui#28841close #681