Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes #62

Merged
merged 4 commits into from
Aug 27, 2023
Merged

Various fixes #62

merged 4 commits into from
Aug 27, 2023

Conversation

EduardSergeev
Copy link
Owner

@EduardSergeev EduardSergeev commented Aug 26, 2023

  • Fix:
    • OrganizeExtensionProvider: false positive of Extension are unorganised
      Aligned extension were incorrectly detected as being not aligned
    • ImportProvider: Organize imports behaviour on Windows
      Fix invalid parsing of imports in file with \r\n (Windows) line ending
      As a result applying Organize imports would previously lead to corrupted imports
    • Fail CI build in case of test failure:
      Previously build would still be green even if some of the test wer failing

@EduardSergeev EduardSergeev marked this pull request as draft August 26, 2023 20:52
Fail entire build if any test in `Run tests` fails
Fix false positive of `extensions not aligned` situation
Previously aligned extension were incorrectly detected as being not aligned
It was not working correctly with `\r\n` (Windows) line endings
@EduardSergeev EduardSergeev changed the title Fix Run tests failure reporting Various fixes Aug 27, 2023
@EduardSergeev EduardSergeev marked this pull request as ready for review August 27, 2023 03:07
@EduardSergeev EduardSergeev merged commit b770082 into master Aug 27, 2023
24 checks passed
@EduardSergeev EduardSergeev deleted the fix/test-step-failure-report branch August 27, 2023 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant