Allennlp Predictor class that mimics gec_model #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y gec_model, get_token_action removed and placed in model.
There's a bug in here somewhere though because the output isn't exactly the same. I suspect there's an off by one error happening when the indices for edit operations are generated.
…l words and corrected words to the output.
… errors are identified. Fixing offsets in light of addition of START_TOKEN to front.
Everything works now except that the text is getting lowercased somewhere.
…offsets when creating the target (corrected sentence). Copying get_token_action method almost verbatim instead of using something more clever.
…. This is identical to the output for gec_model!
Frost45
reviewed
Sep 28, 2022
|
Sorry! I forgot to add Nitin and Damien to the list of reviewers somehow. |
desilinguist
approved these changes
Sep 29, 2022
There was a problem hiding this comment.
I am not that familiar with this codebase so I am going to approve based on what I see and let @Frost45 and @damien2012eng do a more careful review.
|
Great work, @ksteimel ! |
damien2012eng
approved these changes
Oct 5, 2022
Co-authored-by: Sanjna Kashyap <20379363+Frost45@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the large PR. These changes introduce a gec_predictor class that is able to mimic the behavior of gec_model but in a way that follows the allennlp api.
This does handle multi-iteration prediction. However, gec_model had an option for ensemble prediction and that is currently not handled here.
I have also created a model archive that can be used with this new predictor. You can see the config file for this in test_fixtures/roberta_model. The weights file is downloaded the appropriate location and shared between the predictor and gec_model.. I can tar the folder up and then add it to a public s3 bucket after this PR is approved.