Skip to content

Commit

Permalink
Merge branch '406-errors-in-docstring' of https://github.com/Educatio…
Browse files Browse the repository at this point in the history
…nalTestingService/rsmtool into 406-errors-in-docstring
  • Loading branch information
aloukina committed Mar 19, 2020
2 parents ab96e80 + ec61cd7 commit 8f9f4e2
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion rsmtool/utils/metrics.py
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,7 @@ def difference_of_standardized_means(y_true_observed,

# if the population means and standard deviations were not provided, calculate from the data
# We only check for mean since the function requires
# both of these to be set of both to be None
# both of these to be set or both to be None
if population_y_true_observed_mn is None:

warnings.warn(warning_msg.format('y_true_observed'))
Expand Down
16 changes: 8 additions & 8 deletions tests/test_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -428,10 +428,10 @@ def test_difference_of_standardized_means_zero_population_sd_pred():
np.array([2, 1, 4, 1, 5, 2, 2, 2, 2, 2]))
expected = None
diff_std_means = difference_of_standardized_means(y_true, y_pred,
population_y_true_observed_mn=2.44,
population_y_true_observed_sd=0.54,
population_y_pred_mn=2.44,
population_y_pred_sd=0)
population_y_true_observed_mn=2.44,
population_y_true_observed_sd=0.54,
population_y_pred_mn=2.44,
population_y_pred_sd=0)
eq_(diff_std_means, expected)


Expand All @@ -440,10 +440,10 @@ def test_difference_of_standardized_means_zero_population_sd_human():
np.array([2, 1, 4, 1, 5, 2, 2, 2, 2, 2]))
expected = None
diff_std_means = difference_of_standardized_means(y_true, y_pred,
population_y_pred_mn=2.44,
population_y_pred_sd=0.54,
population_y_true_observed_mn=2.44,
population_y_true_observed_sd=0)
population_y_pred_mn=2.44,
population_y_pred_sd=0.54,
population_y_true_observed_mn=2.44,
population_y_true_observed_sd=0)
eq_(diff_std_means, expected)


Expand Down

0 comments on commit 8f9f4e2

Please sign in to comment.