Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pip installation succeeds without installing dependencies #26

Closed
jkahn opened this issue Jul 6, 2016 · 7 comments
Closed

Pip installation succeeds without installing dependencies #26

jkahn opened this issue Jul 6, 2016 · 7 comments
Assignees

Comments

@jkahn
Copy link
Contributor

jkahn commented Jul 6, 2016

I think it should probably fail or at least specify that the dependencies need to be installed.

mkvirtualenv rsmtool-tester --python=/usr/bin/python3
cd $checkoutdir
pip install .
... # succeeds quietly
@desilinguist
Copy link
Member

Fair point. I'm not sure how to make it fail but I can mention explicitly
in the readme that pip is not supported.
On Wed, Jul 6, 2016 at 6:59 PM Jeremy G. Kahn notifications@github.com
wrote:

I think it should probably fail or at least specify that the dependencies
need to be installed.

mkvirtualenv rsmtool-tester --python=/usr/bin/python3
cd $checkoutdir
pip install .
... # succeeds quietly


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#26, or mute
the thread
https://github.com/notifications/unsubscribe/AAJ3kB7Pv8OVBem4TAZ5UWQq-CW8masoks5qTDNdgaJpZM4JGlig
.

@jkahn
Copy link
Contributor Author

jkahn commented Jul 6, 2016

... or make it work?

@desilinguist
Copy link
Member

I'd rather not. I much prefer conda to pip now since it's much simpler and easier to use but I'm happy to accept a PR if anyone really wants it.

@jkahn
Copy link
Contributor Author

jkahn commented Jul 6, 2016

tox virtualenvs still don't understand conda, and I still count on PyPI for distribution most of the time.

I'm doing some tinkering with a requirements.txt file, and I wonder if you can clarify if any part of this is a library or if it's entirely an app? (Maybe a separate issue again.)

@desilinguist
Copy link
Member

It's not that I haven't tried getting it to work with pip but I found that
doing so interfered with building conda packages which is unacceptable.

To answer your other question, RSMTool is also used as a library in some of
our ETS-internal applications.
On Wed, Jul 6, 2016 at 7:15 PM Jeremy G. Kahn notifications@github.com
wrote:

tox virtualenvs still don't understand conda, and I still count on PyPI
for distribution most of the time.

I'm doing some tinkering with a requirements.txt file, and I wonder if you
can clarify if any part of this is a library or if it's entirely an app?
(Maybe a separate issue again.)


You are receiving this because you commented.

Reply to this email directly, view it on GitHub
#26 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAJ3kAA1aj2CDWTZ6XygL8TWBmlvw9-7ks5qTDcigaJpZM4JGlig
.

@desilinguist
Copy link
Member

desilinguist commented Jul 26, 2016

This will probably work better when we upgrade statsmodels to 0.8.1 which has a wheel available for all OSes and not just OS X.

@desilinguist desilinguist added this to the 5.2 milestone Jul 27, 2016
@desilinguist desilinguist self-assigned this Jul 27, 2016
@jbiggsets jbiggsets added this to To Do in rsmtool-refactor Jan 9, 2018
@desilinguist desilinguist removed this from the 5.2 milestone Feb 15, 2018
@desilinguist desilinguist moved this from To Do to In progress in rsmtool-refactor Feb 15, 2018
@desilinguist
Copy link
Member

Addressed by #178.

@desilinguist desilinguist moved this from In progress to Done in rsmtool-refactor Feb 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

2 participants