Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate testing on Windows using Azure Pipelines #309

Merged
merged 5 commits into from
Nov 1, 2019

Conversation

desilinguist
Copy link
Member

@desilinguist desilinguist commented Oct 29, 2019

Addresses #308.

  • Add azure-pipelines.yml file to configure the build system on Azure.
  • Add DistributeTests.ps1 powershell script to divide up tasks on 5 parallel agents just like Travis CI.

@coveralls
Copy link

coveralls commented Oct 29, 2019

Coverage Status

Coverage remained the same at 91.024% when pulling f81ed87 on add-azure-pipelines into ad35063 on master.

@desilinguist
Copy link
Member Author

desilinguist commented Oct 29, 2019

Weird, I wonder why the Azure build shows as passing even though one of the sub-builds fails.

Update: Hmm, it shows as "Succeeded with issues" if you hover over it or click on it but still shows a green checkmark for some reason.

@desilinguist
Copy link
Member Author

Okay, I changed the the config file to not do that.

@desilinguist
Copy link
Member Author

There's a single test failing on Windows. And it's failing because numpy.int maps to a C long which basically maps to a 32-bit number on Windows instead of 64-bit.

@desilinguist
Copy link
Member Author

desilinguist commented Oct 30, 2019

Okay, I have fixed the test and this PR is ready for review @aloukina @jbiggsets @hlepp.

Copy link
Contributor

@jbiggsets jbiggsets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor questions. Looks good to me!

# join all test files seperated by space. pytest runs multiple test files in following format pytest test1.py test2.py test3.py
$testFiles = $testsToRun -Join " "
Write-Host "Test files $testFiles"
# write these files into variable so that we can run them using pytest in subsequent task.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way we can add a check to make sure all new test_* files are added?

Copy link
Member Author

@desilinguist desilinguist Nov 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't really think of any obvious way to do that right now.

@desilinguist desilinguist merged commit cb83964 into master Nov 1, 2019
@delete-merged-branch delete-merged-branch bot deleted the add-azure-pipelines branch November 1, 2019 16:44
srhrshr pushed a commit to srhrshr/rsmtool that referenced this pull request Oct 23, 2021
…ingService/add-azure-pipelines

Integrate testing on Windows using Azure Pipelines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants