New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow run functions to accept pathlib.Path objects #386
Conversation
Hello @aloukina! Thanks for updating this PR.
Comment last updated at 2020-02-26 20:10:10 UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't reviewed the details but had a more overarching comment that'd be good to think about now.
@@ -764,15 +766,15 @@ def _check_config_is_loaded(self): | |||
|
|||
|
|||
@classmethod | |||
def get_configparser(cls, filepath, *args, **kwargs): | |||
def get_configparser(cls, config_file_or_obj_or_dict, *args, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, might it make more sense to just move this logic to the ConfigurationParser()
initializer instead of having this classmethod since all we are doing is getting the args and then calling the initializer anyway?
This PR addresses #384.