Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update report generation to work with latest nbconvert #484

Merged
merged 4 commits into from
Oct 29, 2020
Merged

Update report generation to work with latest nbconvert #484

merged 4 commits into from
Oct 29, 2020

Conversation

desilinguist
Copy link
Member

This PR closes #471.

  • Update the reporting code and template.
  • Remove nbconvert pin.
  • Include asyncio + CPython 3.8 workaround to make sure things work on Windows.

@coveralls
Copy link

coveralls commented Oct 29, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.02%) to 93.053% when pulling 7a0d414 on 471-update-template-for-latest-nbconvert into c712987 on main.

mulhod
mulhod approved these changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@mulhod mulhod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I tested out environment creation and some tests that generate reports. I didn't try on Windows, though. Just wanted to give an extra check for OSX.

aloukina
aloukina approved these changes Oct 29, 2020
View reviewed changes
Copy link
Collaborator

@aloukina aloukina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - thank you for figuring this out!

rsmtool/reporter.py Show resolved Hide resolved
@desilinguist desilinguist merged commit 8759f5b into main Oct 29, 2020
@delete-merged-branch delete-merged-branch bot deleted the 471-update-template-for-latest-nbconvert branch October 29, 2020 22:07
srhrshr pushed a commit to srhrshr/rsmtool that referenced this pull request Oct 23, 2021
@desilinguist
Merge pull request EducationalTestingService#484 from EducationalTest…
9d23671 
…ingService/471-update-template-for-latest-nbconvert

Update report generation to work with latest nbconvert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mulhod mulhod mulhod approved these changes

@aloukina aloukina aloukina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unpin nbconvert when upstream fix is released
4 participants
@desilinguist @coveralls @mulhod @aloukina