Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove np.warnings from fairness_utils.py. #580

Merged
merged 1 commit into from
Jan 3, 2023

Conversation

desilinguist
Copy link
Member

Closes #579.

Numpy v1.24 removes the warnings alias so we need to use warnings directly in fairness_utils.py.

@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Base: 93.08% // Head: 93.08% // No change to project coverage 👍

Coverage data is based on head (f12ed79) compared to base (272e97e).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #580   +/-   ##
=======================================
  Coverage   93.08%   93.08%           
=======================================
  Files          31       31           
  Lines        4529     4529           
=======================================
  Hits         4216     4216           
  Misses        313      313           
Impacted Files Coverage Δ
rsmtool/fairness_utils.py 86.95% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@desilinguist desilinguist merged commit 5fe384b into main Jan 3, 2023
@delete-merged-branch delete-merged-branch bot deleted the bugfix/579-fix-fairness-utils-for-numpy-1-24 branch January 3, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RSMTool fairness section is broken with numpy 1.24
3 participants