Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin dependencies and fix minor issues #666

Merged
merged 5 commits into from
Jan 4, 2024

Conversation

desilinguist
Copy link
Member

  • Unpin numpy and sphinx in requirements.txt and update SKLL to v4.0.1.
  • Update all RSMTool models in test data to avoid warnings from scikit-learn.
  • Replace deprecated pandas applymap() method for Python versions > 3.8 to avoid deprecation warnings.
  • Update dependencies for ReadTheDocs build.

- Also update SKLL to v4.0.1.
Update all RSMTool models to be compatible with latest SKLL and scikit-learn.
Use `map()` instead of the deprecated `applymap()`.
Update dependency versions in `doc/requirements.txt`.
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (bd2085c) 95.85% compared to head (e3c18b5) 95.83%.

Files Patch % Lines
rsmtool/preprocessor.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #666      +/-   ##
==========================================
- Coverage   95.85%   95.83%   -0.02%     
==========================================
  Files          32       32              
  Lines        4485     4488       +3     
==========================================
+ Hits         4299     4301       +2     
- Misses        186      187       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@desilinguist
Copy link
Member Author

We can ignore the change in coverage since this build uses python 3.8 and the decrease is expected.

@desilinguist desilinguist merged commit cf8e813 into main Jan 4, 2024
9 of 12 checks passed
@delete-merged-branch delete-merged-branch bot deleted the 583-644-unpin-numpy-and-sphinx branch January 4, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants