Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No warning is raised if ablation flag is used with train_file/test_file #313

Closed
mulhod opened this issue Mar 2, 2016 · 1 comment
Closed

Comments

@mulhod
Copy link
Contributor

mulhod commented Mar 2, 2016

A warning should be raised if a user has specified a train_file/test_file in their config file and then tries to use ablation when running run_experiment. No featuresets are specified, so there's nothing to ablate. No errors occur and the experiments seem to finish fine, but the results don't make much sense in terms of the labels that are given to them. Probably a warning should be raised and the use of the ablation flag ignored OR an exception should be raised since it's unclear what the user is trying to do. Perhaps mention could be made that the user will have to specify a train_directory/test_directory in order to specify featuresets and/or that, in order to be able to ablate with each feature in a file, a different file will (currently) have to be made for each individual feature and specified as a featureset separately. (This last issued is related to another issue and the behavior might change if dealt with.)

@desilinguist desilinguist added this to the 1.3.1 milestone Feb 13, 2017
@desilinguist desilinguist modified the milestones: 1.3.1, 1.5 Aug 18, 2017
@desilinguist
Copy link
Member

Addressed by #392.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants