Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only show "folds_file" warning when "folds_file" is specified #404

Closed
Lguyogiro opened this issue Dec 19, 2017 · 1 comment
Closed

Only show "folds_file" warning when "folds_file" is specified #404

Lguyogiro opened this issue Dec 19, 2017 · 1 comment
Assignees
@Lguyogiro
Projects
SKLL Release 1.5.1
Milestone
1.5.1

Comments

@Lguyogiro
Copy link
Contributor

Currently, config.py logs the following warning

experiment - WARNING - Specifying "folds_file" overrides both explicit and default "num_cv_folds".

regardless of whether or not "folds_file" is specified, which is a little confusing. We should only log the warning when folds_file is specified.
@Lguyogiro Lguyogiro self-assigned this Dec 19, 2017
@desilinguist desilinguist added this to the 1.5.1 milestone Dec 19, 2017
@desilinguist desilinguist added this to In progress in SKLL Release 1.5.1 Dec 19, 2017
@desilinguist desilinguist moved this from In progress to Done in SKLL Release 1.5.1 Dec 19, 2017
@desilinguist
Copy link
Member

Addressed by #405.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Lguyogiro Lguyogiro

Labels
None yet
Projects
No open projects
SKLL Release 1.5.1
  
Done
Milestone
1.5.1
Development

No branches or pull requests
2 participants
@desilinguist @Lguyogiro