Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

put folds_file warning in correct code block #405

Merged
merged 1 commit into from
Dec 19, 2017

Conversation

Lguyogiro
Copy link
Contributor

This is a tiny bug fix that moves the Specifying "folds_file" overrides both explicit and default "num_cv_folds" warning to make sure it only gets logged when "folds file" has been specified. The existing unit tests make sure this warning is triggered under the appropriate circumstances.

@desilinguist desilinguist self-requested a review December 19, 2017 20:33
@coveralls
Copy link

coveralls commented Dec 19, 2017

Coverage Status

Coverage remained the same at 92.523% when pulling 6905183 on fix_folds_file_warning into 1e3f860 on master.

@aoifecahill aoifecahill self-requested a review December 19, 2017 21:02
Copy link
Member

@desilinguist desilinguist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants