Expose cv_folds and stratified #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
| if num_cv_folds: | ||
| try: | ||
| cv_folds = int(num_cv_folds) | ||
| except: |
There was a problem hiding this comment.
It's probably better to specify a ValueError explicitly here.
There was a problem hiding this comment.
I'm not sure what you mean? There is a ValueError raised?
There was a problem hiding this comment.
Sorry, I meant that you want to catch a ValueError explicitly in the except clause.
There was a problem hiding this comment.
don't I do that?
There was a problem hiding this comment.
Here's the code I see:
if num_cv_folds:
try:
cv_folds = int(num_cv_folds)
except:
raise ValueError("The value for cv_folds should be an integer. " +
"You specified {}".format(num_cv_folds))Here's what I am saying it should look like:
if num_cv_folds:
try:
cv_folds = int(num_cv_folds)
except ValueError:
raise ValueError("The value for cv_folds should be an integer. " +
"You specified {}".format(num_cv_folds))Note the difference in the except statement.
There was a problem hiding this comment.
Oh I see, will update.
desilinguist
added a commit
that referenced
this pull request
Jul 11, 2015
…-nonstratified-xval Expose cv_folds and stratified
This was referenced Jul 11, 2015
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #222 and #160.
New options available in config file:
cv_folds: specify the number of folds for cross validationrandom_folds: when set to True, does not do stratified cross-validationAdded documentation for above options.
Added missing documentation for
grid_search_folds.Fixed an apparent bug in
experiments.pywhere the value ofgrid_search_foldsset in the config file was being overwritten as 3 for model training when the task was not cross validation.