Fix errors when using reusing relative paths in output section #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…some unit tests for that (and )
…_paths_in_output_section_252
|
This looks really good! Only thing - you should probably modify |
…_paths_in_output_section_252
…or config._locate_file and config._parse_config_file in test_input.py
|
Thanks! Looks good to me. |
desilinguist
changed the title
|
Looks good to me. |
desilinguist
added a commit
that referenced
this pull request
Feb 16, 2016
…_when_using_reusing_relative_paths_in_output_section_252 Fix errors when using reusing relative paths in output section
desilinguist
deleted the
feature/errors_when_using_reusing_relative_paths_in_output_section_252
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added in support of relative paths in config files for more than just the training/test set files (e.g. model directory, custom learner, etc.) + some unit tests.