fit() in rescaled() decorator should return self
#306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aoifecahill can you also look at this please? |
|
Looks good to me, thanks! |
|
Looks good to me too! |
desilinguist
added a commit
that referenced
this pull request
Feb 23, 2016
…d-fit-return-self `fit()` in `rescaled()` decorator should return `self`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
fit()method in therescaled()decorator does not returnselfwhich is generally whatfit()methods inscikit-learnshould do.I fixed that and also modified the
test_rescaling()regression test to also test rescaled learners without using grid search. So, we have new tests to check for this functionality which we didn't have before which is probably why this bug slipped through,