Add learning curve plotting command #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desilinguist
requested review from
aoifecahill,
mulhod,
Lguyogiro and
jbiggsets
|
Thank God! This is now ready for review :) |
aoifecahill
approved these changes
Dec 7, 2017
| #!/usr/bin/env python | ||
| # License: BSD 3 clause | ||
| """ | ||
| Little helper script to generate learning plots from the learning curve output TSV file. |
There was a problem hiding this comment.
Is it worth adding a sentence about why this would be necessary?
There was a problem hiding this comment.
Good call. I will do that.
Lguyogiro
reviewed
Dec 7, 2017
| if not exists(args.output_dir): | ||
| makedirs(args.output_dir) | ||
|
|
||
| # check that we have pandas and seaborn available other |
There was a problem hiding this comment.
Is this supposed to say "otherwise throw an error" or something along those lines?
There was a problem hiding this comment.
I was just supposed to stop at "available" but forgot to delete the last word :) I will fix it in the next PR. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plot_learning_curvesthat generates learning curve PNG files from learning curve summary TSV files.