Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix resaving of older models #407

Merged
merged 1 commit into from
Jan 9, 2018
Merged

Fix resaving of older models #407

merged 1 commit into from
Jan 9, 2018

Conversation

desilinguist
Copy link
Member

  • Change deletion of logger attribute from the Learner object to be conditional on whether it exists since older models will not have such an attribute.

@desilinguist
Fix resaving of older models
d5bc864 
- Change deletion of `logger` attribute from the Learner object to be conditional on whether it exists since older models will not have such an attribute.
@desilinguist desilinguist added this to the 1.5.1 milestone Jan 9, 2018
@desilinguist desilinguist self-assigned this Jan 9, 2018
@desilinguist desilinguist removed this from Done in SKLL Release 1.5.1 Jan 9, 2018
@coveralls
Copy link

coveralls commented Jan 9, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.003%) to 92.525% when pulling d5bc864 on fix-resave-older-models into 7b85738 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 92.525% when pulling d5bc864 on fix-resave-older-models into 7b85738 on master.

@desilinguist desilinguist merged commit 322749b into master Jan 9, 2018
@desilinguist desilinguist deleted the fix-resave-older-models branch January 9, 2018 21:18
@desilinguist desilinguist mentioned this pull request Jan 9, 2018
Closed
@benbuleong benbuleong mentioned this pull request Feb 11, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aoifecahill aoifecahill aoifecahill approved these changes

@mulhod mulhod mulhod approved these changes

@jbiggsets jbiggsets Awaiting requested review from jbiggsets

Assignees

@desilinguist desilinguist

Labels
None yet
Projects
None yet
Milestone
1.5.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@desilinguist @coveralls @aoifecahill @mulhod