-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix output directory creation #409
Conversation
- this will test the automatic directory creation.
Ugh, stupid coveralls! :( |
@aoifecahill @Lguyogiro @benbuleong @jbiggsets This is now ready for review. Please actually try an experiment on your local machines with directories to make sure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, and worked for me.
@benbuleong since you filled the original issue, can you please review this? @aoifecahill if you could test it too, it'd be great! |
@desilinguist : Sure, I will review it by EOD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I tried it out and it worked for me :)
_locate_file()
was being called and we were depending on its return value to decide whether to create the output directories or not. However_locate_file()
raises an exception when the file doesn't already exist, so this was a total waste of time.output
directory fromtest_output.py
such that the automatic directory creation will be tested.