Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly handle unlabeled data in multiple places in SKLL #453

Merged
merged 9 commits into from Feb 11, 2019
Merged

Properly handle unlabeled data in multiple places in SKLL #453

merged 9 commits into from Feb 11, 2019

Commits on May 16, 2018

  1. update 'has_labels' in featureset to return False if all labels are None

    Robert Pugh committed May 16, 2018
    Configuration menu
    Copy the full SHA
    efef911 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2018

  1. add featureset test

    Robert Pugh committed May 17, 2018
    Configuration menu
    Copy the full SHA
    14ac9ec View commit details
    Browse the repository at this point in the history

Commits on May 18, 2018

  1. add test data

    Robert Pugh committed May 18, 2018
    Configuration menu
    Copy the full SHA
    f0b515b View commit details
    Browse the repository at this point in the history

  2. fix test data path

    Robert Pugh committed May 18, 2018
    Configuration menu
    Copy the full SHA
    610bfbb View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2019

  1. Allow skll_convert to handle unlabaled input data 

    - Add `--no_labels` option to `skll_convert`
- Make `--no_labels` and `--label_col` mutually exclusive and add test for this.
- Remove `.ndj` from conversion test since it's identical to `.jsonlines` and just adds to the test time.
    @desilinguist
    desilinguist committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    54e8f79 View commit details
    Browse the repository at this point in the history

  2. Fix has_labels to recognize list of None's

    @desilinguist
    desilinguist committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    d515782 View commit details
    Browse the repository at this point in the history

  3. Fix bug in ARFFWriter 

    We do not need to add/remove `label_col` from the fieldnames if it's None to begin with.
    @desilinguist
    desilinguist committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    faf511e View commit details
    Browse the repository at this point in the history

  4. Update test_convert_featureset to also test for unlabeled data 

    - Remove unnecessary test and associated files.
    @desilinguist
    desilinguist committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    a84f7dc View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into unlabelled-readwrite-compatibility 

    # Conflicts:
#	skll/data/featureset.py
    @desilinguist
    desilinguist committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    df20b46 View commit details
    Browse the repository at this point in the history