Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove default value of objective function and objective config field. #458

Merged
merged 30 commits into from
Feb 13, 2019
Merged

Remove default value of objective function and objective config field. #458

merged 30 commits into from
Feb 13, 2019

Commits on Feb 7, 2019

  1. Remove objective field and remove default values for objectives 

    - Remove code for normalizing and error checking the two since there is now only one field.
- Add an additional check that `objectives` is not empty when running an experiment.
    @desilinguist
    desilinguist committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    9bfd068 View commit details
    Browse the repository at this point in the history

  2. Fix a comment and fix flake8 issues.

    @desilinguist
    desilinguist committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    42aa09d View commit details
    Browse the repository at this point in the history

  3. Remove default value of grid objective and learning curve metric 

    - Make default value of `grid_objective` to be `None` for `train()` and `cross_validate()` and add a check in `train()` that raises an exception if we are doing grid search and the objective is not specified.
- Make `metric` a required parameter for `learning_curve()`.
- flake8 fixes.
    @desilinguist
    desilinguist committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    642aad0 View commit details
    Browse the repository at this point in the history

  4. Add new test for empty objectives and remove unnecessary tests 

    - No longer need test for the removed `objective` field.
- Fix other tests that were using `objective` to now use `objectives`.
- flake8 fixes
    @desilinguist
    desilinguist committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    1840b99 View commit details
    Browse the repository at this point in the history

  5. Explicitly specify an objective for tests 

    - Since there's no longer a default value.
- flake8 fixes.
    @desilinguist
    desilinguist committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    826d10d View commit details
    Browse the repository at this point in the history

  6. flake8 fix

    @desilinguist
    desilinguist committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    352596a View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2019

  1. Update all templates to replace objective with objectives.

    @desilinguist
    desilinguist committed Feb 8, 2019
    Configuration menu
    Copy the full SHA
    9ea1fe4 View commit details
    Browse the repository at this point in the history

  2. Tweak parallelization to deal with empty objectives.

    @desilinguist
    desilinguist committed Feb 8, 2019
    Configuration menu
    Copy the full SHA
    cfdbbc6 View commit details
    Browse the repository at this point in the history

  3. Do not use 'score' in tests for no grid search.

    @desilinguist
    desilinguist committed Feb 8, 2019
    Configuration menu
    Copy the full SHA
    022c25f View commit details
    Browse the repository at this point in the history

  4. Move the error checking for missing grid objectives 

    - We only need to check this for specific tasks.
    @desilinguist
    desilinguist committed Feb 8, 2019
    Configuration menu
    Copy the full SHA
    7b42998 View commit details
    Browse the repository at this point in the history

  5. Add new test for learning curve task 

    - To check that missing objectives is fine for this task.
    @desilinguist
    desilinguist committed Feb 8, 2019
    Configuration menu
    Copy the full SHA
    acdfe40 View commit details
    Browse the repository at this point in the history

  6. Fix test that previously passed to raise error 

    - Since there are no default objectives now.
    @desilinguist
    desilinguist committed Feb 8, 2019
    Configuration menu
    Copy the full SHA
    f4c558a View commit details
    Browse the repository at this point in the history

  7. grid_objective -> grid_objectives everywhere.

    @desilinguist
    desilinguist committed Feb 8, 2019
    Configuration menu
    Copy the full SHA
    505a5fd View commit details
    Browse the repository at this point in the history

  8. We need two conditions not just one 

    - We don't want the objective in the name of the output files if (a) it was not specified to begin with or (b) if there was only one objective since then it's obvious which file is which.
    @desilinguist
    desilinguist committed Feb 8, 2019
    Configuration menu
    Copy the full SHA
    24d5552 View commit details
    Browse the repository at this point in the history

  9. Only print 'score' when available 

     - It will not be available if we aren't doing grid search
    @desilinguist
    desilinguist committed Feb 8, 2019
    Configuration menu
    Copy the full SHA
    bed25a8 View commit details
    Browse the repository at this point in the history

  10. Ignore grid_objectives if we aren't doing grid search 

    - This would prevent unnecesary computation in cases when grid search was false but the user still specified a list of objectives.
    @desilinguist
    desilinguist committed Feb 8, 2019
    Configuration menu
    Copy the full SHA
    5d02977 View commit details
    Browse the repository at this point in the history

  11. Make docstring for test shorter

    @desilinguist
    desilinguist committed Feb 8, 2019
    Configuration menu
    Copy the full SHA
    3a321ff View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2019

  1. Shorter docstring

    @desilinguist
    desilinguist committed Feb 9, 2019
    Configuration menu
    Copy the full SHA
    7085863 View commit details
    Browse the repository at this point in the history

  2. Replace 'score' with 'accuracy' for no grid search

    @desilinguist
    desilinguist committed Feb 9, 2019
    Configuration menu
    Copy the full SHA
    876344b View commit details
    Browse the repository at this point in the history

  3. Fix tests 

    - replace 'objective' with 'objectives'
- explicitly specify grid search in places
- do not rely on default values of objectives
- shorter docstrings
    @desilinguist
    desilinguist committed Feb 9, 2019
    Configuration menu
    Copy the full SHA
    3fccea6 View commit details
    Browse the repository at this point in the history

  4. Remove unnecessary file.

    @desilinguist
    desilinguist committed Feb 9, 2019
    Configuration menu
    Copy the full SHA
    ffa4b52 View commit details
    Browse the repository at this point in the history

  5. Add new test for no grid search with list of objectives

    @desilinguist
    desilinguist committed Feb 9, 2019
    Configuration menu
    Copy the full SHA
    b4a1709 View commit details
    Browse the repository at this point in the history

  6. Add explicit objectives to test

    @desilinguist
    desilinguist committed Feb 9, 2019
    Configuration menu
    Copy the full SHA
    9499aa3 View commit details
    Browse the repository at this point in the history

  7. Several flake8 fixes

    @desilinguist
    desilinguist committed Feb 9, 2019
    Configuration menu
    Copy the full SHA
    d7cf274 View commit details
    Browse the repository at this point in the history

  8. Do not rely on 'score' 

    - Specify `grid_objective` explicitly when calling `train()`.
- Some flake8 fixes
    @desilinguist
    desilinguist committed Feb 9, 2019
    Configuration menu
    Copy the full SHA
    8fc66ae View commit details
    Browse the repository at this point in the history

  9. Fix silly teardown issue 

    - For some reason the same file was being appended to.
    @desilinguist
    desilinguist committed Feb 9, 2019
    Configuration menu
    Copy the full SHA
    8603e14 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2019

  1. Revert typo from earlier commit.

    @desilinguist
    desilinguist committed Feb 11, 2019
    Configuration menu
    Copy the full SHA
    5d94271 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into remove-default-objective

    @desilinguist
    desilinguist committed Feb 11, 2019
    Configuration menu
    Copy the full SHA
    07c4598 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2019

  1. Add new test to check for bad learning curve cv folds

    @desilinguist
    desilinguist committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    571b858 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2019

  1. Show offending type in TypeError.

    @desilinguist
    desilinguist committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    570d324 View commit details
    Browse the repository at this point in the history