removing deprecated mean_squared_error, cv_folds_file and objectives in learning curve #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desilinguist
requested changes
Feb 25, 2019
| @@ -1751,7 +1789,7 @@ def test_learning_curve_objectives_and_no_metrics(): | |||
| eq_(grid_objectives, []) | |||
|
|
|||
|
|
|||
| def test_learning_curve_default_objectives_and_no_metrics(): | |||
| def test_learning_curve_no_metrics(): | |||
There was a problem hiding this comment.
Shouldn't this test raise an error? Is there a default learning curve metric?
There was a problem hiding this comment.
This test is calling check_config_parsing_value_error which raises ValueError. There is no default metrics. Instead, I can change this test case to call _parse_config_file and raise exception if you think that would be better.
desilinguist
requested changes
Mar 14, 2019
|
Do we really need these two lines if we are raising a ValueError anyway? I think that's also why the coverage is going down. |
desilinguist
approved these changes
Mar 14, 2019
desilinguist
deleted the
feature/deprecate-things-with-deprecation-warnings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the support for
mean_squared_error,cv_folds_fileandobjectivesin learning curve.mean_squared_erroris replaced byneg_mean_squared_errorcv_folds_fileis replaced byfolds_fileobjectivesin learning curve is replaced bymetricsinoutputsection