Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Boston dataset from examples and tests. #717

Merged
merged 3 commits into from Sep 12, 2022

Conversation

desilinguist
Copy link
Member

This PR closes #700.

Replace boston dataset with california dataset everywhere.

  • Remove boston example and replace with new california example.
  • Remove make_boston_example_data.py script and add make_california_example_data.py script instead and sub-sample the full dataset is huge.
  • Remove references to boston dataset from everywhere.
  • Remove boston example test data and add california example test data.
  • Replace boston name in sample test data.

- Remove boston example and replace with new california example.
- Remove `make_boston_example_data.py` script and add
  `make_california_example_data.py` script instead and sub-sample
  since the full dataset is huge.
- Remove references to boston dataset from everywhere.
- Remove boston example test data and add california example test data.
@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Base: 96.90% // Head: 96.90% // No change to project coverage 👍

Coverage data is based on head (8f5b6f7) compared to base (c49147b).
Patch coverage: 22.22% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #717   +/-   ##
=======================================
  Coverage   96.90%   96.90%           
=======================================
  Files          63       63           
  Lines        9271     9271           
=======================================
  Hits         8984     8984           
  Misses        287      287           
Impacted Files Coverage Δ
examples/make_california_example_data.py 0.00% <0.00%> (ø)
skll/experiments/output.py 97.38% <ø> (ø)
tests/test_regression.py 99.64% <ø> (ø)
tests/test_examples.py 98.36% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

doc/run_experiment.rst Show resolved Hide resolved
@desilinguist desilinguist merged commit bdf6107 into main Sep 12, 2022
@delete-merged-branch delete-merged-branch bot deleted the 700-replace-boston-dataset branch September 12, 2022 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace boston dataset in tests and examples
3 participants