New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infrastructure for logging to wandb #758
Conversation
Hello @tamarl08! Thanks for updating this PR.
Comment last updated at 2023-12-08 16:02:50 UTC |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #758 +/- ##
==========================================
+ Coverage 95.30% 95.33% +0.02%
==========================================
Files 29 30 +1
Lines 3580 3598 +18
==========================================
+ Hits 3412 3430 +18
Misses 168 168 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason the coverage checks are not being met?
I added a test for run_configuration with W&B and now it's covered. I don't know why it did not count as covered before, those lines are tested at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for adding the new test!
This PR adds initial infrastructure for W&B logging, including a configuration field to enable W&B, a wand interface class, documentation and tests.