Remove check on line 142 #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An array is not being passed in to the during function so you cannot use the preg_grep("/ /", $dates) function which requires an array.
|
@oliver204 , |
|
No worries, thanks for amending :)
… On 4 Mar 2017, at 18:42, Eduardo Marcos ***@***.***> wrote:
@oliver204 <https://github.com/oliver204> ,
Thanks for pointing out that bug in during clause :)
I fixed that and kept the check in order to prevent hitting google API with wrong date format.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGgOr0bcZJemSVUSpMfeSpyc8xUzwNSaks5ribCxgaJpZM4MS3ln>.
|
Edujugon
added a commit
that referenced
this pull request
Apr 10, 2017
Edujugon
added a commit
that referenced
this pull request
Apr 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An array is not being passed in to the during function so you cannot use the preg_grep("/ /", $dates) function which requires an array.