Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce size of docker image #84

Merged
merged 2 commits into from
Oct 17, 2022
Merged

Conversation

pan3793
Copy link
Contributor

@pan3793 pan3793 commented Oct 17, 2022

Changelog category (leave one)

  • Other

Changelog entry (Details of this change)

Reduce size of docker image by leveraging command ADD

Affected version

latest version

Copy link
Member

@qianmoQ qianmoQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Message that will be displayed on users' first pull request

@pan3793
Copy link
Contributor Author

pan3793 commented Oct 17, 2022

Sorry, I can not pass the test locally, it failed w/

=> ERROR [internal] load metadata for docker.io/library/java:8

If you don't mind, I would recommend switching to eclipse-temurin:8-jdk-focal, it was adopted by a bunch of apache projects like Apache Spark.

@qianmoQ
Copy link
Member

qianmoQ commented Oct 17, 2022

Sorry, I can not pass the test locally, it failed w/

=> ERROR [internal] load metadata for docker.io/library/java:8

If you don't mind, I would recommend switching to eclipse-temurin:8-jdk-focal, it was adopted by a bunch of apache projects like Apache Spark.

This is a good suggestion. You can modify it and submit it again

@pan3793
Copy link
Contributor Author

pan3793 commented Oct 17, 2022

updated

@pan3793
Copy link
Contributor Author

pan3793 commented Oct 17, 2022

This is an interesting project, and I'm glad to see it supports Apache Kyuubi (incubating) officially, do you want to add the Datacap integration guide to Kyuubi docs[1]? The entry point of the codebase at [2]. I think both projects will benefit from it.

BTW, is EdurtIO a commercialized organization or a community organization? If the latter, are there criteria to join?

[1] https://kyuubi.readthedocs.io/en/latest/client/index.html
[2] https://github.com/apache/incubator-kyuubi/tree/master/docs/client

@qianmoQ
Copy link
Member

qianmoQ commented Oct 17, 2022

This is an interesting project, and I'm glad to see it supports Apache Kyuubi (incubating) officially, do you want to add the Datacap integration guide to Kyuubi docs[1]? The entry point of the codebase at [2]. I think both projects will benefit from it.

BTW, is EdurtIO a commercialized organization or a community organization? If the latter, are there criteria to join?

[1] https://kyuubi.readthedocs.io/en/latest/client/index.html [2] https://github.com/apache/incubator-kyuubi/tree/master/docs/client

Open source community organization, feel free to join

@qianmoQ
Copy link
Member

qianmoQ commented Oct 17, 2022

LGTM, thanks for your contribtue!

@qianmoQ qianmoQ added the enhancement New feature or request label Oct 17, 2022
@qianmoQ qianmoQ added this to the 1.1.0.20221115 milestone Oct 17, 2022
@qianmoQ qianmoQ merged commit 51c65af into devlive-community:develop Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants