Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fatal error on implement Fcm\Request #19

Closed
MagroGames opened this issue Dec 6, 2019 · 3 comments
Closed

Fatal error on implement Fcm\Request #19

MagroGames opened this issue Dec 6, 2019 · 3 comments

Comments

@MagroGames
Copy link

Dear developer,

I'm getting an PHP fatal error on the Notification class.
It seems an easy fix, but I wasn't sure because you should've seen the same error as i'm seeing right now:

PHP Fatal error: Class Fcm\Push\Notification contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (Fcm\Request::getUrl) in ***/vendor/edwinhoksberg/php-fcm/src/Push/Notification.php on line 8

I don't see the implementation in the Notification class, I do see it in the Data and Push class...
Could you clarify for me please?

@rolinger
Copy link
Collaborator

@MagroGaming - did you get this resolved? Post your code. Also, you should be using my fork as there are many fixes, additions and better support documentation in my fork. We should be splitting my fork out as its own project soon as this original project is no longer supported by its creator.

@rolinger
Copy link
Collaborator

@MagroGaming - we just made a bunch of fixes and merged the new build. Try retesting now.

@AndyGaskell
Copy link
Collaborator

I think we can close this now.

@MagroGaming please re-open it if you're still having this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants