Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Guzzle options to prevent PHP fatal error #26

Merged

Conversation

FrenchBully
Copy link
Contributor

Description

NOT critical: Added Client options to pass on as an array to GuzzleHTTP client.

Related issues

#2
#19

Release Summary

  • created second arguments for Fcm/Client send function.
  • the argument is an array of options to be passed through GuzzleHTTPClient

Checklist

  • This is a breaking change;
    • Yes
    • No

Test Plan

The client is still functional and does not produce additional errors.

@AndyGaskell
Copy link
Collaborator

Hi @FrenchBully sorry, I only just noticed this.

I've not had a proper look, but sounds like it'd overlap with bits we discussed in...
#17 Fatal Error if tokenID is not found using \Fcm\Device\Info

I'll try test this out with a view to merging it in the next week or so.

@AndyGaskell AndyGaskell merged commit 333a546 into EdwinHoksberg:master Jul 30, 2020
@AndyGaskell
Copy link
Collaborator

Looks good, thanks @FrenchBully

@AndyGaskell AndyGaskell added the enhancement New feature or request label Jul 30, 2020
@rolinger
Copy link
Collaborator

I recall the guzzle issues way back when, thanks for adding the guzzle options. However, where is the documentation on how to manage that? I looked through several of the docs and don't see mention of what the guzzle options are or how to implement.

@AndyGaskell
Copy link
Collaborator

Yea, I've just been double checking this, am now wondering if it was a mistake to merge it

@rolinger
Copy link
Collaborator

rolinger commented Aug 5, 2020

@AndyGaskell - So, what was the final outcome for the guzzle options? Been really busy so I have only been glancing at the email comms. The only guzzle documentation om the project that I can find was my original work around : https://github.com/EdwinHoksberg/php-fcm/blob/master/docs/device.rst

Has this changed?

AndyGaskell added a commit that referenced this pull request Aug 7, 2020
docs and tweaks

Adding Guzzle options

Main discussion is in #27

See also...
#17
#26
AndyGaskell added a commit that referenced this pull request Aug 7, 2020
Main discussion is in #27

See also...
#17
#26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants