Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird event calls for entity_action #332

Closed
SiverDX opened this issue May 20, 2023 · 9 comments
Closed

Weird event calls for entity_action #332

SiverDX opened this issue May 20, 2023 · 9 comments
Assignees

Comments

@SiverDX
Copy link

SiverDX commented May 20, 2023

Type: origins:action_on_callback

When leaving a world:
entity_action_removed

When joining a world:
n/a

When chosing a power:
entity_action_removed
entity_action_lost

When a power is chosen:
entity_action_added
entity_action_chosen

Now the real weird one - when dying:
entity_action_added
entity_action_removed
entity_action_lost
entity_action_added
entity_action_removed
entity_action_respawned

If remove gets called when leaving a world then added should be called when joining it
And when dying it should only call respawned

@MerchantPug
Copy link
Collaborator

I'll be testing this one alongside the original Fabric version, and will be aiming for parity with that.
Thanks for bringing up that there may be inconsistencies with that.

@MerchantPug
Copy link
Collaborator

MerchantPug commented Jul 21, 2023

I've tested and everything is consistent with the Fabric version apart from Action on Respawned

You have made two errors when it comes to what's running.

The corrections (Origins Forge)

When joining a world:
entity_action_added

(I can't blame you for this one, I only found it because of logs)

When respawning:
entity_action_added
entity_action_removed
entity_action_respawned

Origins Fabric On Respawned

entity_action_removed
entity_action_added
entity_action_respawned

This is where the trouble comes in, as this is the imparity here.

@MerchantPug MerchantPug self-assigned this Jul 21, 2023
@SiverDX
Copy link
Author

SiverDX commented Jul 21, 2023

I added logs to the powers so this event call chain definitely happened like this

there might be some incompatibility with some other mod then I guess

@MerchantPug
Copy link
Collaborator

MerchantPug commented Jul 21, 2023

I did too, maybe you were reading prior logs for On Respawn?

@SiverDX
Copy link
Author

SiverDX commented Jul 21, 2023

definitely not

image

image

@MerchantPug
Copy link
Collaborator

MerchantPug commented Jul 21, 2023

Alright, that's incredibly strange that you were getting those results. I'd probably see if it's an incompatibility on your end.

@MerchantPug
Copy link
Collaborator

MerchantPug commented Jul 22, 2023

Okay, I think that I understand the issue now. Are you using a multiple?

Nevermind.

@SiverDX
Copy link
Author

SiverDX commented Jul 22, 2023

havent been using the mod for a while now, what i remember is that it was some illager origin from https://www.curseforge.com/minecraft/mc-mods/bucolic-origins

i added the different origins:action_on_callback types to one of the powers (i think illagerteam) to find the cause of some problem i had

(i saw the nevermind but maybe the info is relevant for something)

@MerchantPug
Copy link
Collaborator

MerchantPug commented Jul 22, 2023

That's fair, I'm currently resolving this issue with somebody else (see #345). My guess is that another mod is recreating the player on respawn.

Thanks for the feedback, and I'll probably leave you to your business.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants