Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.20.1 Forge] Scroll / additional info appearing randomly #371

Closed
MrKashew opened this issue Sep 23, 2023 · 6 comments
Closed

[1.20.1 Forge] Scroll / additional info appearing randomly #371

MrKashew opened this issue Sep 23, 2023 · 6 comments

Comments

@MrKashew
Copy link

MrKashew commented Sep 23, 2023

Having this very strange bug where when I first join my server at times I will not be able to see further information about an origin (no scroll etc)

image

but upon kicking + rejoining I can see it

image

debug.log
latest.log

I tried this without Origins++ (and XL packets) and was receiving this issue - so not sure what could be the cause yet

@MerchantPug
Copy link
Collaborator

MerchantPug commented Sep 23, 2023

I swore that I fixed this during dev-time. wtf.

@MerchantPug
Copy link
Collaborator

I forgot to handle this this patch, but this patch was sorta split into 2 patches anyways, so you're in luck.

@Thspooks
Copy link

Thspooks commented Nov 21, 2023

Having same bug on 1.19.2, on newest version for it

MerchantPug added a commit to EdwinMindcraft/calio that referenced this issue Dec 10, 2023
@MerchantPug
Copy link
Collaborator

MerchantPug commented Dec 10, 2023

Fixed for next 1.20.1 update.

@MerchantPug
Copy link
Collaborator

MerchantPug commented Dec 10, 2023

Basically the 🤓 rundown is two things.

  1. We sorted a set for syncing to the client, but we didn't set it to be an actual sorted set, so the sorting meant nothing.
  2. Even if the above was the case, the check for if there's a loading order wasn't what it should've been, so everything would've output -1 in the sort (basically meaning random order).

@MerchantPug
Copy link
Collaborator

If anybody is still running into this, it may be fixed with the registry fixes.

MerchantPug added a commit to EdwinMindcraft/calio that referenced this issue Mar 13, 2024
MerchantPug added a commit to EdwinMindcraft/calio that referenced this issue Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants