Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in_tag Damage condition doesn't exist (1.20 1.10.0.5) #414

Closed
muon-rw opened this issue Jan 26, 2024 · 6 comments
Closed

in_tag Damage condition doesn't exist (1.20 1.10.0.5) #414

muon-rw opened this issue Jan 26, 2024 · 6 comments
Assignees

Comments

@muon-rw
Copy link

muon-rw commented Jan 26, 2024

Trying to use this damage condition at all results in the condition failing to load with Unknown registry key: origins:in_tag

This feature exists in 1.10.0 for Origins Fabric.

Looking at the condition/damage package in Apoli Forge, it looks like this was just never added.
I am blind, but for some reason I am getting this error.

@muon-rw
Copy link
Author

muon-rw commented Jan 26, 2024

Looks like the condition type was created, but simply not registered.

@MerchantPug
Copy link
Collaborator

Will fix next update, thanks for looking into it.

@Cynic1254
Copy link

I am having the same issue for origins:type as well (I haven't looked through the code but I am getting the exact same error as when using in_tag) any idea when this will be fixed?

@MerchantPug
Copy link
Collaborator

MerchantPug commented Mar 11, 2024

I am having the same issue for origins:type as well (I haven't looked through the code but I am getting the exact same error as when using in_tag) any idea when this will be fixed?

I don't remember an origins:type existing. Could you please link me it on the docs?

MerchantPug added a commit to EdwinMindcraft/apoli that referenced this issue Mar 11, 2024
@Cynic1254
Copy link

I am having the same issue for origins:type as well (I haven't looked through the code but I am getting the exact same error as when using in_tag) any idea when this will be fixed?

I don't remember an origins:type existing. Could you please link me it on the docs?

https://origins.readthedocs.io/en/latest/types/damage_condition_types/type/

@muon-rw
Copy link
Author

muon-rw commented Mar 11, 2024

I am having the same issue for origins:type as well (I haven't looked through the code but I am getting the exact same error as when using in_tag) any idea when this will be fixed?

I don't remember an origins:type existing. Could you please link me it on the docs?

https://origins.readthedocs.io/en/latest/types/damage_condition_types/type/

This damage condition type was added after Origins 1.10, and is 1.20.2+ only on Fabric.

@MerchantPug MerchantPug self-assigned this Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants