Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.20.1] exposed_to_sun is actually checking the z+1 position #439

Closed
LTCatt opened this issue Apr 20, 2024 · 5 comments
Closed

[1.20.1] exposed_to_sun is actually checking the z+1 position #439

LTCatt opened this issue Apr 20, 2024 · 5 comments

Comments

@LTCatt
Copy link

LTCatt commented Apr 20, 2024

image
image

Tests fine in Origins (Fabric)
Version: 1.20.1-1.10.0.1

@LTCatt LTCatt changed the title [1.20.1] origins:exposed_to_sun is actually checking the z+1 position [1.20.1] exposed_to_sun is actually checking the z+1 position Apr 20, 2024
@MerchantPug
Copy link
Collaborator

MerchantPug commented Apr 23, 2024

Thanks for this report. Ill fix it when i can.

@LTCatt
Copy link
Author

LTCatt commented May 2, 2024

It relates to the negative coordinates. At (100, 100) the detection is perfectly fine, but at (-100, -100) it is detecting (-99, -99).
I'm sorry, but is there an expected time for this to be fixed? My players are already abusing this bug :/

@MerchantPug
Copy link
Collaborator

Expect a release in the first or second week of this month.

@MerchantPug
Copy link
Collaborator

MerchantPug commented May 3, 2024

Okay, I've gone in and fixed the issue.

The issue was that the conversion of the exposed_to_sky condition check did not use the block position of the entity, but rather the regular position, with dropped decimals.

So standing on -99.5 would result in checking -99, rather than -100.

MerchantPug added a commit to EdwinMindcraft/apoli that referenced this issue May 3, 2024
@MerchantPug
Copy link
Collaborator

Will be fixed in Origins Forge 1.10.0.8

MerchantPug added a commit to EdwinMindcraft/apoli that referenced this issue May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants