Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launching remarkable-hacks patched xochitl with Oxide breaks L+R shortcut for Zen Mode #147

Open
nullstalgia opened this issue Jan 14, 2021 · 3 comments
Assignees
Labels
bug Something isn't working 📱 reMarkable 1

Comments

@nullstalgia
Copy link

When using ddvk's hack, pressing L and R at the same time enables a special mode while in a notebook. However, the launcher does not pass through both buttons when they are pressed at the same time. I am unable to tell which one is pushed instead.

Version Information:

  • Device: reMarkable 1
  • OS: 2.5.0.27
  • Version 2.0.3~beta-1

Thanks!

@nullstalgia nullstalgia added bug Something isn't working to-triage This needs to be triaged labels Jan 14, 2021
@Eeems
Copy link
Collaborator

Eeems commented Jan 14, 2021

This is likely due to how the buttons are being handled, it's not echoing them both through as being pressed at the same time. Thus it's echoing them through as one being pressed and release, and then the other one.

Not entirely sure how to work around this.

@nullstalgia
Copy link
Author

Generally, I think people will push them together under the 700ms mark.

I have a few suggestions, but without knowing how your code is set up:

  1. Checking to see if the other button was pushed at any point before the first was released

or

  1. Measure the time difference between both buttons being pressed down, and see if its within a certain treshold

or

  1. After releasing the first button, wait 200ms and see if the other button is released in that time.

@Eeems
Copy link
Collaborator

Eeems commented Jan 15, 2021

My code would have to be modified to allow it to send button presses for multiple buttons at the same time. A button press send is an atomic action right now. It's possible to do, but not going to be easy.

You do have a workaround for now though, which is to long press on the top left corner to toggle zen mode.

@Eeems Eeems removed the to-triage This needs to be triaged label Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 📱 reMarkable 1
Projects
None yet
Development

No branches or pull requests

2 participants